Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjump: 1.3.1 -> 1.15 #94405

Merged
merged 1 commit into from Aug 13, 2020
Merged

openjump: 1.3.1 -> 1.15 #94405

merged 1 commit into from Aug 13, 2020

Conversation

syberant
Copy link
Member

@syberant syberant commented Aug 1, 2020

Motivation for this change

I was trying to fix #38452 but ended up updating the version at the same time because it was very old at this point.
@das-g, I don't use this software myself so I can't very well test if everything works. I just know the basics work like drawing the UI. Would you be so friendly as to test whether this solves your problems and doesn't create new ones?

Also for any reviewer: I am very uncertain about how to package shell scripts so some feedback and suggestions when I'm doing it wrong would be much appreciated! It does work though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
Copy link
Member

das-g commented Aug 1, 2020

Result of nixpkgs-review pr 94405 1

1 package built:
- openjump

@das-g
Copy link
Member

das-g commented Aug 1, 2020 •
edited

@das-g, I don't use this software myself so I can't very well test if everything works. I just know the basics work like drawing the UI.

I've only yet used OpenJump to display data. So if you've drawn in it (i.e. created new data or edited existing one) you've done more with it than I ever have.

Edit: Sorry, I've misread. I see now that you wrote about "drawing the UI", so I assume you mean just getting the UI to display.

Would you be so friendly as to test whether this solves your problems and doesn't create new ones?

This PR does indeed solve #38452: With this change OpenJump can be launched without the user having to care how to provide a JRE to it. 👍

@das-g
Copy link
Member

das-g commented Aug 1, 2020

@das-g, I don't use this software myself so I can't very well test if everything works.

I've just tested it by downloading the *.shp.zip from https://download.geofabrik.de/europe/liechtenstein.html and opening that within OpenJump (even without unpacking the Zip archive first).

✔️ Seems to work fine and displays the content:

Bildschirmfoto von 2020-08-01 10-21-47

@syberant
Copy link
Member Author

syberant commented Aug 1, 2020

Edit: Sorry, I've misread. I see now that you wrote about "drawing the UI", so I assume you mean just getting the UI to display.

Yes, I did mean just getting the UI to display.

I've just tested it by downloading the *.shp.zip from https://download.geofabrik.de/europe/liechtenstein.html and opening that within OpenJump (even without unpacking the Zip archive first).

heavy_check_mark Seems to work fine and displays the content:

Great, thanks very much for testing.

Also, pinging @MarcWeber here as he is the maintainer.

@Lassulus Lassulus merged commit 5415651 into NixOS:master Aug 13, 2020
@syberant syberant deleted the openjump branch August 13, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenJump should depend on Java
3 participants
@syberant @das-g @Lassulus