Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-wlrobs: 20200111 -> 20200622 #94400

Merged
merged 1 commit into from Aug 6, 2020
Merged

obs-wlrobs: 20200111 -> 20200622 #94400

merged 1 commit into from Aug 6, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 1, 2020

Motivation for this change

A bug was fixed a month ago.

https://todo.sr.ht/~scoopta/wlrobs/14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from grahamc August 1, 2020 03:26
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/239

@bbigras
Copy link
Contributor Author

bbigras commented Aug 5, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 5, 2020
@bbigras
Copy link
Contributor Author

bbigras commented Aug 5, 2020

/status needs_reviewer

@srhb
Copy link
Contributor

srhb commented Aug 6, 2020

LGTM. I don't have the ability to test obs with wayland, however.

@srhb srhb merged commit 2032df1 into NixOS:master Aug 6, 2020
@bbigras bbigras deleted the obs-wlrobs branch August 6, 2020 18:41
@bbigras
Copy link
Contributor Author

bbigras commented Aug 6, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @nixos-discourse @srhb