Implement Animation::setTimeline #24832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 31, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
4 times, most recently
from
cf37b06
to
5659426
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
2 times, most recently
from
66a678a
to
3f48734
Compare
|
@birtles Contains update to WPT tests to address recent changes to how play state is calculated as well as sets for scroll timelines. |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
from
3f48734
to
457988f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
from
457988f
to
a4632d6
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
3 times, most recently
from
b54ce14
to
a4a47d7
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
2 times, most recently
from
46a43e1
to
7687e19
Compare
Mutability of the animation timeline is behind the feature flag for ScrollTimeline. The feature is marked as web-exposed, but with a no-op implementation if the feature flag is not set. The rationale for this setup is that we don't support conditionally readonly attributes in IDL. With the patch, a number of the failing tests are now failing for different reasons: * Replaceable animations should consider all timelines when determining if an animation can be removed. Our current implementation only considers other animations on the same timeline when making the decision. Fixing these failures requires some refactoring, which is deferred to a followup CL. * Resetting the timeline cancels a running CSS animation or transition. Some refactoring is required to ensure that we properly compute the cancel time as it depends on the old timeline. Again, deferring to a followup CL. w3c/csswg-drafts#5159 w3c/csswg-drafts#5422 https://drafts.csswg.org/scroll-animations-1 https://www.chromestatus.com/feature/6752840701706240 Bug: 827626 Change-Id: I1fea09a80e8730694455c06b192cb9e068eb0c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324101 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805371}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324101
branch
from
7687e19
to
89d6f57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutability of the animation timeline is behind the feature flag for
ScrollTimeline. The feature is marked as web-exposed, but with a no-op
implementation if the feature flag is not set. The rationale for this
setup is that we don't support conditionally readonly attributes in IDL.
With the patch, a number of the failing tests are now failing for
different reasons:
if an animation can be removed. Our current implementation only
considers other animations on the same timeline when making the
decision. Fixing these failures requires some refactoring, which is
deferred to a followup CL.
Some refactoring is required to ensure that we properly compute the
cancel time as it depends on the old timeline. Again, deferring to
a followup CL.
w3c/csswg-drafts#5159
w3c/csswg-drafts#5422
https://drafts.csswg.org/scroll-animations-1
https://www.chromestatus.com/feature/6752840701706240
Bug: 827626
Change-Id: I1fea09a80e8730694455c06b192cb9e068eb0c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324101
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805371}