Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-deny: 0.7.0 -> 0.8.5 #94367

Merged
merged 6 commits into from Jan 18, 2021
Merged

cargo-deny: 0.7.0 -> 0.8.5 #94367

merged 6 commits into from Jan 18, 2021

Conversation

matthiasbeyer
Copy link
Contributor

Does not build for me though, tests fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jul 31, 2020

Will take a look at the failing test.

@Ma27
Copy link
Member

Ma27 commented Jul 31, 2020

@matthiasbeyer the issue is reproducible with 0.7.1 and 0.7.2 when building the sources in a git checkout where all dependencies are fetched using cargo vendor, so the vendoring seems to be the culprit.

For me it'd be fine to skip the test for now as it's an upstream bug, however we should report this problem to the developers.

@matthiasbeyer
Copy link
Contributor Author

Ping. What is needed from me?

@Ma27
Copy link
Member

Ma27 commented Oct 9, 2020

Eval error looks unrelated (#100071).

@GrahamcOfBorg build cargo-deny

@matthiasbeyer matthiasbeyer changed the title cargo-deny: 0.7.0 -> 0.7.2 cargo-deny: 0.7.0 -> 0.8.2 Nov 2, 2020
@matthiasbeyer
Copy link
Contributor Author

Another update,... will this land before cargo-deny hits version 1.0?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 94367 run on x86_64-darwin 1

1 package failed to build:
  • cargo-deny
failures:                                                                                                                                                                                                                                                                                                                                                                               ---- cyclic_dependencies_do_not_cause_infinite_loop stdout ----                                                                                                                             thread 'cyclic_dependencies_do_not_cause_infinite_loop' panicked at 'called `Result::unwrap()` on an `Err` value: failed to build crate graph

Caused by:
    0: Error during execution of `cargo metadata`: error: failed to select a version for the requirement `winapi = "=0.3.8"`
       candidate versions found which didn't match: 0.3.9
       location searched: directory source `/private/tmp/nix-build-cargo-deny-0.8.2.drv-0/cargo-deny-0.8.2-vendor.tar.gz` (which is replacing registry `https://github.com/rust-lang/crates.io-index`)
       required by package `ansi_term v0.11.0`
           ... which is depended on by `root v0.1.0 (/private/tmp/nix-build-cargo-deny-0.8.2.drv-0/source/tests/test_data/cyclic_dependencies/root)`
       perhaps a crate was updated and forgotten to be re-vendored?

    1: Error during execution of `cargo metadata`: error: failed to select a version for the requirement `winapi = "=0.3.8"`
       candidate versions found which didn't match: 0.3.9
       location searched: directory source `/private/tmp/nix-build-cargo-deny-0.8.2.drv-0/cargo-deny-0.8.2-vendor.tar.gz` (which is replacing registry `https://github.com/rust-lang/crates.io-index`)
       required by package `ansi_term v0.11.0`
           ... which is depended on by `root v0.1.0 (/private/tmp/nix-build-cargo-deny-0.8.2.drv-0/source/tests/test_data/cyclic_dependencies/root)`
       perhaps a crate was updated and forgotten to be re-vendored?
       ', tests/bans.rs:10:60
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    cyclic_dependencies_do_not_cause_infinite_loop

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test bans'

@matthiasbeyer
Copy link
Contributor Author

Seems like cargo metadata is missing in the environment during the tests...

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 25, 2020 •
edited

Seems like cargo metadata is missing in the environment during the tests...

Can you please add it or disable the test? This also errors on linux.

@matthiasbeyer
Copy link
Contributor Author

If you tell me how to or even provide me with a patch, that'd be awesome!

@matthiasbeyer matthiasbeyer changed the title cargo-deny: 0.7.0 -> 0.8.2 cargo-deny: 0.7.0 -> 0.8.5 Dec 17, 2020
@matthiasbeyer
cargo-deny: 0.7.0 -> 0.7.2
e0eca24
@matthiasbeyer
cargo-deny: 0.7.2 -> 0.7.3
9cd2b88 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
cargo-deny: 0.7.3 -> 0.8.2
4689c60 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Cargo-deny: 0.8.2 -> 0.8.4
5f9b236 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
cargo-deny: 0.8.4 -> 0.8.5
9a55066 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
cargo-deny: Disable tests
4b98792 
Because nobody told me how to add the missing cargo-metadata command to
the test environment and the PR for updating this package is almost
half a year old, disable tests now.

Hopefully someone will step up and fix this, but I doubt it.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 94367 run on x86_64-linux 1

1 package built:
  • cargo-deny

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 94367 run on x86_64-darwin 1

1 package built:
  • cargo-deny

@SuperSandro2000 SuperSandro2000 merged commit a3d00ab into NixOS:master Jan 18, 2021
@matthiasbeyer matthiasbeyer deleted the update-cargo-deny branch January 18, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @Ma27 @SuperSandro2000