Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel-builder/menuconfig: Use pkg-config wrapper #187

Merged
merged 1 commit into from Jul 21, 2020

Conversation

samueldr
Copy link
Member

This works around an issue with upstream Nixpkgs and the way pkg-config
is now (admitedly rightly so) prefixed.

In actuality, the kernel build should be fixed upstream, but this would
be a non-trivial thing to get into the kernel.

This was verified with:

  • pine64-pinephone-braveheart
  • asus-dumo
  • asus-z00t (should be a no-op)
  • motorola-addison (should be a no-op)

cc @s1ng0c

@samueldr samueldr changed the title kernel-builder: Use pkg-config wrapper kernel-builder/menuconfig: Use pkg-config wrapper Jul 17, 2020
This works around an issue with upstream Nixpkgs and the way pkg-config
is now (admitedly rightly so) prefixed.

In actuality, the kernel build should be fixed upstream, but this would
be a non-trivial thing to get into the kernel.
@samueldr samueldr mentioned this pull request Jul 19, 2020
@samueldr samueldr added the 4. type: bug Something isn't working label Jul 21, 2020
@samueldr samueldr merged commit d94486c into NixOS:master Jul 21, 2020
@samueldr samueldr deleted the fix/menuconfig-pkg-config branch July 21, 2020 00:19
@samueldr samueldr added the 4. type: regression Something stopped working label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: bug Something isn't working 4. type: regression Something stopped working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant