Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles/base: adding ifenslave #93346

Closed
wants to merge 1 commit into from
Closed

profiles/base: adding ifenslave #93346

wants to merge 1 commit into from

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 17, 2020 •
edited

Motivation for this change

In some enterprise datacenter, the network is setup with LACP 802.3ad by default. In order to get a network connection, you need to create a bonded interface. For this to happen, the ifenslave utility is indeed in additional to ip/ifconfig.

I would like to propose to add this to our default profile for the installation medias, give the utility itself is only 36K, but extremly useful when dealing in non-cloud environments.

36K	/nix/store/sgii49fyg2pcsih78h6fmx1dk5bmjp21-ifenslave-1.1.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jul 17, 2020

Since this is indeed very small and only impacting the install media, I think it looks okay to me:

[nix-shell:~/Downloads/thinking-intensifies]$ ldd /nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0/bin/ifenslave
	linux-vdso.so.1 (0x00007ffcc79d5000)
	libc.so.6 => /nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/libc.so.6 (0x00007fbf12737000)
	/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib/ld-linux-x86-64.so.2 => /nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30/lib64/ld-linux-x86-64.so.2 (0x00007fbf128f8000)

[nix-shell:~/Downloads/thinking-intensifies]$ nix-store --query --requisites /nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0/bin/ifenslave
/nix/store/mxaxvp33wg9sim8qh2kkw041v492bvxj-libunistring-0.9.10
/nix/store/hjng28vbd73qq9iz9j8r397x19aa8fp9-libidn2-2.3.0
/nix/store/xg6ilb9g9zhi2zg1dpi4zcp288rhnvns-glibc-2.30
/nix/store/vga49x750d5hljxrblib1rza8k9fb1ix-ifenslave-1.1.0

@ajs124
Copy link
Member

ajs124 commented Jul 17, 2020

What can ifenslave do that ip link cannot? Creating a bond and adding slave devices to it are definitely possible.

@mmahut
Copy link
Member Author

mmahut commented Jul 17, 2020

What can ifenslave do that ip link cannot? Creating a bond and adding slave devices to it are definitely possible.

Oh, damn, today I have learned... :) thank you for letting me know.

@mmahut mmahut closed this Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @grahamc @ajs124