Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: Link libfaac to fix audio recording #93374

Merged
merged 1 commit into from Jul 18, 2020
Merged

zoom-us: Link libfaac to fix audio recording #93374

merged 1 commit into from Jul 18, 2020

Conversation

tadfisher
Copy link
Contributor

Fixes #93341.

Using strace reveals that zoom is attempting to load "libfaac1.so" from
its PATH. As faac provides "libfaac.so.0", solve this by linking from
there to "libfaac1.so" in zoom's output.

This is the same solution as the one we use for libjpeg_turbo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadfisher
zoom-us: Link libfaac to fix audio recording
94a0d8b 
Fixes NixOS#93341.

Using strace reveals that zoom is attempting to load "libfaac1.so" from
its PATH. As faac provides "libfaac.so.0", solve this by linking from
there to "libfaac1.so" in zoom's output.

This is the same solution as the one we use for libjpeg_turbo.
@ofborg ofborg bot requested review from danbst and doronbehar July 17, 2020 23:31
michalrus
michalrus approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@michalrus
Copy link
Member

Since this is a bug, I think it should be backported onto stable?

@veprbl veprbl merged commit 903a0ca into NixOS:master Jul 18, 2020
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 18, 2020
@veprbl veprbl self-assigned this Jul 18, 2020
veprbl pushed a commit that referenced this pull request Jul 21, 2020
@tadfisher @veprbl
zoom-us: Link libfaac to fix audio recording (#93374)
a90a5c5 
Fixes #93341.

Using strace reveals that zoom is attempting to load "libfaac1.so" from
its PATH. As faac provides "libfaac.so.0", solve this by linking from
there to "libfaac1.so" in zoom's output.

This is the same solution as the one we use for libjpeg_turbo.

(cherry picked from commit 903a0ca)
@veprbl veprbl removed their assignment Jul 21, 2020
github-actions bot added a commit to lovesegfault/nix-config that referenced this pull request Jul 22, 2020
@github-actions
niv nixpkgs: update a5cc7d31 -> 5717d9d2
c2bac61 
## Changelog for nixpkgs:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
lovesegfault pushed a commit to lovesegfault/nix-config that referenced this pull request Jul 22, 2020
@github-actions @lovesegfault
niv nixpkgs: update a5cc7d31 -> 5717d9d2
f10f489 
## Changelog for nixpkgs:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
github-actions bot added a commit to pbogdan/nix-hie that referenced this pull request Jul 22, 2020
@github-actions
niv stable: update bb8f0cc2 -> 9ea61f7b
d972c3f 
## Motivation

Dependencies should be up to date.

## Changelog for stable:
Commits: [NixOS/nixpkgs@bb8f0cc2...9ea61f7b](NixOS/nixpkgs@bb8f0cc...9ea61f7)

* [`154c3f30`](NixOS/nixpkgs@154c3f3) nixos/btrfs autoScrub: don't fail when scrub finishes successfully
* [`b061622b`](NixOS/nixpkgs@b061622) networkmanager: 1.22.10 -> 1.22.14
* [`f6e6a291`](NixOS/nixpkgs@f6e6a29) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`df0e7ad3`](NixOS/nixpkgs@df0e7ad) nixos/wireguard: fix typos and unify formatting
* [`a674930d`](NixOS/nixpkgs@a674930) nixos/wireguard: Fix mismatched XML tag
* [`4a9973a0`](NixOS/nixpkgs@4a9973a) haskellPackages.streaming-osm: 1.0.1 -> 1.0.2
* [`d0cd7528`](NixOS/nixpkgs@d0cd752) weechat*: remove myself as maintainer
* [`c146535f`](NixOS/nixpkgs@c146535) oraclejdk: 8u251 -> 8u261
* [`190e79d0`](NixOS/nixpkgs@190e79d) nextcloud: 19.0.0 -> 19.0.1
* [`a90a5c51`](NixOS/nixpkgs@a90a5c5) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`cbf3cb53`](NixOS/nixpkgs@cbf3cb5) grim: 1.3.0 -> 1.3.1
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
github-actions bot added a commit to pbogdan/tag that referenced this pull request Jul 22, 2020
@github-actions
niv unstable: update a5cc7d31 -> 5717d9d2
164be8d 
## Motivation

Dependencies should be up to date.

## Changelog for unstable:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
github-actions bot added a commit to pbogdan/nix-hie that referenced this pull request Jul 22, 2020
@github-actions
niv unstable: update a5cc7d31 -> 5717d9d2
f4024df 
## Motivation

Dependencies should be up to date.

## Changelog for unstable:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
github-actions bot added a commit to pbogdan/nvs that referenced this pull request Jul 22, 2020
@github-actions
niv unstable: update a5cc7d31 -> 5717d9d2
0397d7e 
## Motivation

Dependencies should be up to date.

## Changelog for unstable:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
github-actions bot added a commit to pbogdan/nix-nerd-fonts that referenced this pull request Jul 22, 2020
@github-actions
niv unstable: update a5cc7d31 -> 5717d9d2
3b9e1c1 
## Motivation

Dependencies should be up to date.

## Changelog for unstable:
Commits: [NixOS/nixpkgs@a5cc7d31...5717d9d2](NixOS/nixpkgs@a5cc7d3...5717d9d)

* [`c8adba66`](NixOS/nixpkgs@c8adba6) bsequencer: 1.4.2 -> 1.6.0
* [`65579d4b`](NixOS/nixpkgs@65579d4) flashplayer: 32.0.0.387 -> 32.0.0.403
* [`2370ca0b`](NixOS/nixpkgs@2370ca0) stm32cubemx: 5.3.0 -> 5.6.1
* [`0e2f98d6`](NixOS/nixpkgs@0e2f98d) ucx: 1.7.0 -> 1.8.1
* [`fe2c68a7`](NixOS/nixpkgs@fe2c68a) openmpi: build with ucx support
* [`5601d748`](NixOS/nixpkgs@5601d74) mbelib: init at 1.3.0
* [`f856cb8a`](NixOS/nixpkgs@f856cb8) it++: init at 4.3.1
* [`6f1acf82`](NixOS/nixpkgs@6f1acf8) dsd: init at 2018-07-01
* [`8c5c7d3a`](NixOS/nixpkgs@8c5c7d3) steam-runtime: 0.20200417.0 -> 0.20200604.0
* [`8f5eaa6d`](NixOS/nixpkgs@8f5eaa6) gfan: fix clang build on non-Darwin
* [`fafc1dd8`](NixOS/nixpkgs@fafc1dd) python37Packages.limnoria: 2020.04.11 -> 2020.07.01
* [`5bb86543`](NixOS/nixpkgs@5bb8654) fedora-coreos-config-transpiler: use upstream vendor
* [`4703d4da`](NixOS/nixpkgs@4703d4d) _3270font: init at 2.0.4
* [`f1d5d212`](NixOS/nixpkgs@f1d5d21) barlow: init at 1.422
* [`16d86323`](NixOS/nixpkgs@16d8632) beamerpresenter: 0.1.1 -> 0.1.2
* [`5868f8f3`](NixOS/nixpkgs@5868f8f) strip-nondeterminism: fix build on darwin
* [`8a65fe8d`](NixOS/nixpkgs@8a65fe8) petsc: Fix install_name_tool patch
* [`424936ed`](NixOS/nixpkgs@424936e) cvc4: 1.6 -> 1.8
* [`60c9c3a2`](NixOS/nixpkgs@60c9c3a) sd-switch: init at 0.1.0
* [`9eccd641`](NixOS/nixpkgs@9eccd64) gama: init at 2.09
* [`410dbaa0`](NixOS/nixpkgs@410dbaa) p7zip: fix build when enableUnfree is true
* [`bdc6bb9b`](NixOS/nixpkgs@bdc6bb9) visualvm: 2.0.2 -> 2.0.3
* [`c3bf59ee`](NixOS/nixpkgs@c3bf59e) weechat: 2.8 -> 2.9
* [`72e242d5`](NixOS/nixpkgs@72e242d) coreboot-utils: include common meta attrs for all
* [`903a0cac`](NixOS/nixpkgs@903a0ca) zoom-us: Link libfaac to fix audio recording (NixOS/nixpkgs#93374)
* [`b0778598`](NixOS/nixpkgs@b077859) vimPlugins: update
* [`501a9dec`](NixOS/nixpkgs@501a9de) vimPlugins.elvish-vim: init at 2019-06-29
* [`5096769b`](NixOS/nixpkgs@5096769) vimPlugins.vim-packer: init at 2018-11-11
* [`2904fb7f`](NixOS/nixpkgs@2904fb7) vimPlugins.vim-vagrant: init at 2018-11-11
* [`44178a84`](NixOS/nixpkgs@44178a8) vimPlugins.vim-terraform-completion: init at 2019-07-28
* [`cc7012ac`](NixOS/nixpkgs@cc7012a) vimPlugins.ncm2-cssomni: init at 2018-07-09
* [`260182cd`](NixOS/nixpkgs@260182c) vimPlugins.ncm2-github: init at 2018-08-01
* [`03d23636`](NixOS/nixpkgs@03d2363) vimPlugins.ncm2-html-subscope: init at 2018-07-01
* [`b667ccff`](NixOS/nixpkgs@b667ccf) vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
* [`0e24f744`](NixOS/nixpkgs@0e24f74) vimPlugins.ncm2-neoinclude: init at 2020-01-09
* [`82b1b193`](NixOS/nixpkgs@82b1b19) vimPlugins.ncm2-neosnippet: init at 2019-01-26
* [`466872ec`](NixOS/nixpkgs@466872e) vimPlugins.ncm2-syntax: init at 2018-12-11
* [`fbd0c09e`](NixOS/nixpkgs@fbd0c09) vimPlugins.ncm2-tagprefix: init at 2018-11-08
* [`fc17201a`](NixOS/nixpkgs@fc17201) vimPlugins.ncm2-vim: init at 2018-08-15
* [`f826149d`](NixOS/nixpkgs@f826149) vimPlugins.ncm2-dictionary: init at 2018-11-15
* [`ef0df90c`](NixOS/nixpkgs@ef0df90) vimPlugins: add overrides for new ncm2 plugin deps
* [`a378e69d`](NixOS/nixpkgs@a378e69) jo: 1.3 -> 1.4
* [`27f514ac`](NixOS/nixpkgs@27f514a) etcd_3_4: 3.4.9 -> 3.4.10
* [`a4119588`](NixOS/nixpkgs@a411958) tflint: 0.17.0 -> 0.18.0
* [`949d3913`](NixOS/nixpkgs@949d391) golangci-lint: 1.28.1 -> 1.28.3 (NixOS/nixpkgs#93466)
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalrus michalrus michalrus approved these changes

@danbst danbst Awaiting requested review from danbst

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zoom-us: meeting recordings have no sound
3 participants
@tadfisher @michalrus @veprbl