New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.backoff: init at 1.10.0 #93377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
Would you please change the src
to include tests or otherwise explicitly disable the tests and try pythonImportsCheck
.
pname = "backoff"; | ||
version = "1.10.0"; | ||
|
||
src = fetchPypi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source on Pypi does not include tests. Perhaps you should switch the source to the GitHub repository.
Ran 0 tests in 0.000s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done: It now says 58 passed
as it builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 93377 1
2 packages built:
- python37Packages.backoff
- python38Packages.backoff
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix path-info -S
before and after)0 → 110532768