Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cvc4: 1.6 -> 1.8 #93375

Merged
merged 1 commit into from Jul 18, 2020
Merged

cvc4: 1.6 -> 1.8 #93375

merged 1 commit into from Jul 18, 2020

Conversation

MrChico
Copy link
Contributor

@MrChico MrChico commented Jul 17, 2020

Motivation for this change

Current version of cvc4 is 1.6, which was released on February 11. I want to use cvc4 with https://github.com/LeventErkok/sbv (whose nix package needs to be patched to reuse the proper cvc4, I can do that after this PR)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from vbgl, gebner and thoughtpolice July 18, 2020 00:11
@ofborg ofborg bot requested a review from gebner July 18, 2020 12:03
@gebner
Copy link
Member

gebner commented Jul 18, 2020

Please squash the commits into a single commit!

@MrChico @gebner
cvc4: 1.6 -> 1.8
424936e 
Co-authored-by: Gabriel Ebner <gebner@gebner.org>

Update pkgs/applications/science/logic/cvc4/default.nix

Co-authored-by: Gabriel Ebner <gebner@gebner.org>
@MrChico
Copy link
Contributor Author

MrChico commented Jul 18, 2020

Squashed.

@gebner gebner merged commit 3ffc16a into NixOS:master Jul 18, 2020
@gebner
Copy link
Member

gebner commented Jul 18, 2020

Thanks!

@MrChico MrChico deleted the cvc4_1.8 branch July 18, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrChico @gebner @Janik-Haag