Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: add 8.8.4 (copied from 8.8.3) #93348

Merged
merged 1 commit into from Jul 18, 2020
Merged

ghc: add 8.8.4 (copied from 8.8.3) #93348

merged 1 commit into from Jul 18, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 17, 2020 •
edited

Motivation for this change

https://www.haskell.org/ghc/blog/20200715-ghc-8.8.4-released.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif ggreif changed the base branch from master to haskell-updates July 17, 2020 15:01
@ggreif ggreif changed the title Ghc 8.8.4 ghc: add 8.8.4 (copied from 8.8.3) Jul 17, 2020
@ofborg ofborg bot requested review from kosmikus and peti July 17, 2020 15:09
@ggreif
Copy link
Contributor Author

ggreif commented Jul 17, 2020 •
edited

@GrahamcOfBorg build haskell.compiler.ghc884

peti
peti approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cdepillabout
Copy link
Member

@ggreif Thanks for always sending these GHC updates.

I was able to build haskell.compiler.ghc884, as well as haskell.packages.ghc884.lens on my x86 NixOS system, so I think this should be good to be merged in.

Once you take it off Draft, ping me and I'll merge it in.

Also, would you be willing to backport this to the release-20.03 branch?

@ggreif ggreif marked this pull request as ready for review July 18, 2020 09:55
@ggreif
Copy link
Contributor Author

ggreif commented Jul 18, 2020 •
edited

@cdepillabout I have taken this out of draft. I'll look for an example of a 20.03 backport and follow up.

@peti Enjoy your vacation.

@cdepillabout cdepillabout merged commit 576dc7b into NixOS:haskell-updates Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@kosmikus kosmikus Awaiting requested review from kosmikus

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @cdepillabout @peti