Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell updates #93299

Merged
merged 3 commits into from Jul 17, 2020
Merged

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

massiv* packages are marked as broken. Turns out it is only a test issue. An upstream patch has been accepted to fix this in the next massiv release. This pull disables the massiv test in the meantime.

It also unmarks broken from all the associated packages and dependencies as they appear to be fine after this change (i.e., the resulting libraries build with nix build and work at least well enough to at least run some basic image code I wrote that uses the massiv package).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything here compiles fine on NixOS

@cdepillabout cdepillabout merged commit 5c7338d into NixOS:haskell-updates Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants