Gzdoom: Add mpg123 to RPATH #93329
Draft
Gzdoom: Add mpg123 to RPATH #93329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to latest nixpkgs master
Gzdoom apparently doesn't add mpg123's path to its RPATH properly when built. This patchelf call should fix it.
postInstall won't have a ${gzdoom} when it's inside the gzdoom derivation.
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
not sure if patchelfing a binary we build our self is the right approach? Isn't there some way to configure the searchpath? |
|
I honestly don't know; I barely understand this language as is, and I have
a lot on my plate anyway.
…On Sat, Jul 25, 2020, 5:41 AM Lassulus ***@***.***> wrote:
not sure if patchelfing a binary we build our self is the right approach?
Isn't there some way to configure the searchpath?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#93329 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNXHR62Z4B4HVWT27KFOPLR5KZFDANCNFSM4O5TM55Q>
.
|
SuperSandro2000
requested changes
Nov 29, 2020
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Due to the removal of fmod, gzdoom's mp3 handling has been somewhat broken, and loading a .wad or .pk3 that has an mp3 in it can cause crashes. This change prevents the crash by adding mpg123's location to gzdoom's RPATH, ensuring that gzdoom doesn't panic when it can't find it in all the other places it looks (apparently it was checking everywhere from openAL's folder to SDL2's folder, but not in mpg123's own folder).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)