Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpt: init at v0.31.0 #93330

Merged
merged 1 commit into from Jul 19, 2020
Merged

kpt: init at v0.31.0 #93330

merged 1 commit into from Jul 19, 2020

Conversation

mikefaille
Copy link
Contributor

Motivation for this change

kpt is a shinny new tool from Google to manage kubernetes assets. Let's adopt it on Nixpkg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ]Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails because vendorSha256 is missing. modSha256 will be removed with the next release. See: #89454

Also added some other requested changes.

pkgs/applications/networking/cluster/kpt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kpt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kpt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kpt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/cluster/kpt/default.nix Outdated Show resolved Hide resolved
@mikefaille
Copy link
Contributor Author

mikefaille commented Jul 19, 2020

 Build fails because vendorSha256 is missing. modSha256 will be removed with the next release. See: #89454

I see. I tested the build only with : nix-env -f $NIXPKGS -i kpt
From a stable channel.

Is it possible to test the build fast without using `nixos-rebuild build``on my git branch of nixpkgs ?

@danieldk
Copy link
Contributor

danieldk commented Jul 19, 2020

Is it possible to test the build fast without using `nixos-rebuild build``on my git branch of nixpkgs ?

If you are in the top-level nixpkgs directory, you can run

nix-build -A kpt

This will build the derivation and create a result symlink to the output. You can then peek around in result/ and e.g. run result/bin/kpt. Although I rarely use it, you can also use nix-shell. E.g.:

nix-shell -I nixpkgs=. --pure -p kpt

Which will put you in a development shell as if kpt was a dependency (so you can also run it).

Finally, there is nixpkgs-review, which also builds any package dependent on the package that you changed (though of course, that is less important for a new package).

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for contributing this package and making the requested changes 👍

Result of nixpkgs-review pr 93330 1

1 package built:
- kpt

Tested kpt binary.

@danieldk danieldk merged commit ebbc6ed into NixOS:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants