Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/matrix-synapse: update documentation #93308

Merged
merged 1 commit into from Jul 17, 2020
Merged

nixos/matrix-synapse: update documentation #93308

merged 1 commit into from Jul 17, 2020

Conversation

claudiiii
Copy link
Contributor

Motivation for this change

This changes all occurrences of Riot to Element and adds a sentence about the name change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@claudiiii claudiiii mentioned this pull request Jul 16, 2020
Merged
10 tasks
@worldofpeace worldofpeace requested a review from Ma27 July 17, 2020 01:04
@Ma27
Copy link
Member

Ma27 commented Jul 17, 2020

LGTM, apart from @rnhmjoj's comment.

@Ma27 Ma27 merged commit 25d67fb into NixOS:master Jul 17, 2020
@Ma27
Copy link
Member

Ma27 commented Jul 17, 2020

@claudiiii thanks!

@Ma27 Ma27 mentioned this pull request Jul 24, 2020
Merged
10 tasks
@claudiiii claudiiii deleted the update-element-docs branch February 2, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@claudiiii @Ma27 @rnhmjoj