Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.44.1 -> 1.45.0 #93364

Merged
merged 1 commit into from Jul 18, 2020
Merged

rust: 1.44.1 -> 1.45.0 #93364

merged 1 commit into from Jul 18, 2020

Conversation

alyssais
Copy link
Member

Thunderbird and Firefox don't build with 1.45.

Could a Darwin user please report whether fd builds with this change?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested review from LnL7 and Mic92 as code owners July 17, 2020 18:35
@alyssais
rust: 1.44.1 -> 1.45.0
cd50431 
Thunderbird and Firefox don't build with 1.45.
@zowoq
Copy link
Contributor

zowoq commented Jul 18, 2020 •
edited

fd, gitAndTools.delta, miniserve and ripgrep build successfully on darwin.

For future updates would it be possible to split them by adding the new version first and change the default in another PR so we can test packages without having to build rust from source?

@alyssais
Copy link
Member Author

For future updates would it be possible to split them by adding the new version first and change the default in another PR so we can test packages without having to build rust from source?

I think we’d have a hard time keeping up having to do two sequential PRs every bump.

@alyssais alyssais merged commit e33bed7 into NixOS:staging Jul 18, 2020
@alyssais alyssais deleted the rust branch July 18, 2020 05:18
@edolstra
Copy link
Member

Looks like rustfmt is now broken: https://hydra.nixos.org/build/124188852

error: environment variable `CFG_RELEASE_CHANNEL` not defined
   --> /build/rustc-1.45.0-src/vendor/rustc-ap-rustc_attr/builtin.rs:655:27
    |
655 |             let channel = env!("CFG_RELEASE_CHANNEL");
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `CFG_RELEASE` not defined
   --> /build/rustc-1.45.0-src/vendor/rustc-ap-rustc_attr/builtin.rs:657:48
    |
657 |             let rustc_version = Version::parse(env!("CFG_RELEASE")).unwrap();
    |                                                ^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors

@cole-h
Copy link
Member

cole-h commented Jul 21, 2020

Seems like this changed upstream, see rust-lang/rustfmt#4230 (comment) and https://github.com/rust-lang/rustfmt/blob/master/Contributing.md#building-and-testing.

@cole-h cole-h mentioned this pull request Jul 21, 2020
Merged
10 tasks
@cole-h
Copy link
Member

cole-h commented Jul 21, 2020

Should be fixed by #93600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @zowoq @edolstra @cole-h