Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vivaldi: remove gstreamer #93367

Merged
merged 1 commit into from Jul 22, 2020
Merged

vivaldi: remove gstreamer #93367

merged 1 commit into from Jul 22, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Jul 17, 2020

Works fine (at least for my normal behaviors using the web) running the latest snapshot.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from otwieracz and NeQuissimus July 17, 2020 19:18
@flokli
Copy link
Contributor

flokli commented Jul 17, 2020

Does this mean it's only using ffmpeg?

flokli
flokli requested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the reasoning why this is removed to the PR or the commit message?

@eadwu
Copy link
Member Author

eadwu commented Jul 21, 2020

I'm not sure what you mean by "only using ffmpeg" but this is basically just to unbreak the derivation after gstreamer was marked as broken.

I'm not intimate with the inner workings of how gstreamer ties with the browser, but all my daily activities with the browser still work fine.

@flokli
Copy link
Contributor

flokli commented Jul 21, 2020

Ah, gstreamer being marked as broken fell off my radar.

@eadwu can you check if the test video at https://help.vivaldi.com/article/html5-proprietary-media-on-linux/ plays on that version?

@romildo
Copy link
Contributor

romildo commented Jul 21, 2020

can you check if the test video at https://help.vivaldi.com/article/html5-proprietary-media-on-linux/ plays on that version?

On my system with this PR merged it plays.

@jtojnar jtojnar mentioned this pull request Jul 21, 2020
Closed
70 tasks
@flokli flokli merged commit cd03bf0 into NixOS:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

@romildo romildo romildo approved these changes

@otwieracz otwieracz Awaiting requested review from otwieracz

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @flokli @romildo