Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql80: 8.0.17 -> 8.0.21 #93371

Closed
wants to merge 1 commit into from
Closed

mysql80: 8.0.17 -> 8.0.21 #93371

wants to merge 1 commit into from

Conversation

alyssais
Copy link
Member

Hopefully substituteInPlace will be less brittle than the patch.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
mysql80: 8.0.17 -> 8.0.21
7d4ae0e 
Hopefully substituteInPlace will be less brittle than the patch.
@alyssais
Copy link
Member Author

@GrahamcOfBorg test nixos.mysql

@alyssais
Copy link
Member Author

@GrahamcOfBorg test mysql

@aanderse aanderse mentioned this pull request Sep 19, 2020
Closed
1 task
@aanderse
Copy link
Member

@alyssais you don't happen to have access to a darwin box to figure out the issue, do you?

This was referenced Sep 22, 2020
Closed
Closed
@totten totten mentioned this pull request Jan 11, 2021
Merged
10 tasks
@seamuslee001
Copy link

I believe this is no longer needed now that #109006 has been merged

@alyssais alyssais closed this Jan 14, 2021
@alyssais alyssais deleted the mysql branch January 14, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @aanderse @seamuslee001