Implement #524 Allow flat colors. Adds an edit control for Ambient li… #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whitequark never mind, got it. It seems to work. Setting both lights brightness to zero and the ambient to 1.0 yields flat coloring. |
whitequark
approved these changes
Jul 18, 2020
whitequark
reviewed
Jul 18, 2020
src/confscreen.cpp
Outdated
| @@ -218,6 +224,10 @@ void TextWindow::ShowConfiguration() { | |||
| CO(SS.lightDir[i]), i, &ScreenChangeLightDirection, | |||
| SS.lightIntensity[i], i, &ScreenChangeLightIntensity); | |||
| } | |||
| Printf(false, "%Bp Ambient Lighting " | |||
There was a problem hiding this comment.
Actually, this should be lowercase to follow the style of that dialog.
Suggested change
| Printf(false, "%Bp Ambient Lighting " | |
| Printf(false, "%Bp ambient lighting " |
There was a problem hiding this comment.
Fixed. Good call it's all lower case.
…Ambient lighting.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whitequark can you have a look at the text window code here? The change[c] link isn't working.
When that's fixed we should be able to turn off the 2 directional lights (set intensity to 0) and turn up ambient to 1 to get flat colors.