Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages: lint #93302

Merged
merged 3 commits into from Jul 20, 2020
Merged

dotnetCorePackages: lint #93302

merged 3 commits into from Jul 20, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 16, 2020 •
edited

Motivation for this change

Wanted to do some big edits on dotnet packages, and thought that this PR would be less controversial than my later additions.

  • camelCase to dash-case for filenames
  • used 2 wide spacing
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/93302
18 packages built:
dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python-language-server python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabibackend wasabiwallet

@jonringer jonringer requested a review from baracoder July 16, 2020 21:19
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/work-in-progress-dotnet2nix-builtdotnetproject-helper/8162/7

@ofborg ofborg bot requested a review from kuznero July 16, 2020 21:48
@jonringer
Copy link
Contributor Author

I guess changing the order of rpath causes rebuilds... I think I'll leave that in though, not many packages are being rebuilt

kuznero
kuznero approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@kuznero kuznero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer jonringer merged commit 8dd9563 into NixOS:master Jul 20, 2020
@jonringer jonringer deleted the package-dotnet branch July 20, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder approved these changes

@kuznero kuznero kuznero approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @nixos-discourse @baracoder @kuznero