Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kfp #93310

Closed
wants to merge 3 commits into from
Closed

Add kfp #93310

wants to merge 3 commits into from

Conversation

yixu34
Copy link

@yixu34 yixu34 commented Jul 16, 2020

Motivation for this change

This adds the KubeFlow Pipelines SDK.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ludovicc
Copy link

Failed to build on Darwin

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93310"                                                                                                                 exited environment
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/93310/head:refs/nixpkgs-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 13 (delta 6), reused 6 (delta 6), pack-reused 7
Unpacking objects: 100% (13/13), 1.79 KiB | 131.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 + 8a58662c40c...291fb68b95c refs/pull/93310/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /Users/lclaude/.cache/nixpkgs-review/pr-93310/nixpkgs 3829979d8d29c9f24d52768a0fe485cfb3257a2b
Preparing worktree (detached HEAD 3829979d8d2)
Updating files: 100% (22139/22139), done.
HEAD is now at 3829979d8d2 Merge pull request #86589 from raboof/document-running-perl-scripts-from-the-shell
$ git merge --no-commit 291fb68b95ca3fb4184913a8344e1bcd78c6eb06
Auto-merging pkgs/top-level/python-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/lclaude/.cache/nixpkgs-review/pr-93310/build.nix
builder for '/nix/store/yzdqdhcwb95n8220lx3f9dy58f5jgs12-python3.7-recommonmark-0.6.0.drv' failed with exit code 1; last 10 log lines:
    /private/var/folders/v5/83p3n3f546nc81syhhrfs9mr0000gn/T/nix-build-python3.7-recommonmark-0.6.0.drv-0/source/recommonmark/parser.py:75: UserWarning: Container node skipped: type=document
      warn("Container node skipped: type={0}".format(mdnode.t))

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  =========================== short test summary info ============================
  FAILED tests/test_sphinx.py::GenericTests::test_code - AssertionError: '<pre>...
  FAILED tests/test_sphinx.py::GenericTests::test_headings - AssertionError: '<...
  FAILED tests/test_sphinx.py::GenericTests::test_image - AssertionError: '<p><...
  FAILED tests/test_sphinx.py::GenericTests::test_links - AssertionError: 'This...
  =========== 4 failed, 19 passed, 5 deselected, 19 warnings in 2.31s ============
cannot build derivation '/nix/store/n3mmlgysavsq6jc74vis58djv0gw6ifr-python3.7-kubernetes-11.0.0.drv': 1 dependencies couldn't be built
builder for '/nix/store/hyc5f03nwfkp6jgf8zqngjy07xi7ga0r-python3.8-recommonmark-0.6.0.drv' failed with exit code 1; last 10 log lines:
    /private/var/folders/v5/83p3n3f546nc81syhhrfs9mr0000gn/T/nix-build-python3.8-recommonmark-0.6.0.drv-0/source/recommonmark/parser.py:75: UserWarning: Container node skipped: type=document
      warn("Container node skipped: type={0}".format(mdnode.t))

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  =========================== short test summary info ============================
  FAILED tests/test_sphinx.py::GenericTests::test_code - AssertionError: '<pre>...
  FAILED tests/test_sphinx.py::GenericTests::test_headings - AssertionError: '<...
  FAILED tests/test_sphinx.py::GenericTests::test_image - AssertionError: '<p><...
  FAILED tests/test_sphinx.py::GenericTests::test_links - AssertionError: 'This...
  =========== 4 failed, 19 passed, 5 deselected, 19 warnings in 2.48s ============
cannot build derivation '/nix/store/amkc6hzwwb0ds93r0p7ycb9gqp8lxjm4-python3.8-kubernetes-11.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kcj7skgmmvc42py1jm7lkl0bpwyf74yj-python3.7-kfp-0.5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/rkf6rjc76j2a4lwqhbxgmr3qpfd4q76n-python3.8-kfp-0.5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jkrqj98xapi8grnhgjmmgw0nrr61lzn9-env.drv': 2 dependencies couldn't be built
[11 built (2 failed), 145 copied (181.8 MiB), 35.9 MiB DL]
error: build of '/nix/store/jkrqj98xapi8grnhgjmmgw0nrr61lzn9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/93310
2 packages failed to build:
python37Packages.kfp python38Packages.kfp

6 packages built:
python27Packages.kfp-server-api python27Packages.strip-hints python37Packages.kfp-server-api python37Packages.strip-hints python38Packages.kfp-server-api python38Packages.strip-hints

[0.0 MiB DL]
error: build log of '/nix/store/kcj7skgmmvc42py1jm7lkl0bpwyf74yj-python3.7-kfp-0.5.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/rkf6rjc76j2a4lwqhbxgmr3qpfd4q76n-python3.8-kfp-0.5.1.drv' is not available

@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@carlthome
Copy link
Contributor

Hmm, could this be resurrected perhaps?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 14, 2022
@abathur
Copy link
Member

abathur commented Aug 27, 2023

Tentatively closing this since the previous query about resurrecting it has gone unanswered for over 9 months, but I'm happy to reopen if the author's still interested in pursuing it.

@abathur abathur closed this Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants