Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: 6.4.6 -> 6.10.2 #93363

Merged
merged 1 commit into from Jul 18, 2020
Merged

rocksdb: 6.4.6 -> 6.10.2 #93363

merged 1 commit into from Jul 18, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 17, 2020 •
edited

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Jul 17, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from magenbluten and adevress July 17, 2020 18:53
@danieldk
Copy link
Contributor

@ofborg test ceph-single-node ceph-multi-node samba

danieldk
danieldk approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 93363 1

2 packages failed to build:
- bareos
- sortmerna
7 packages built:
- blockbook
- ceph
- ceph-client
- libceph
- rocksdb
- rocksdb_lite
- samba4Full

bareos is already broken, sortmerna needs some fixes, for which I will do a PR.

I'll merge when ceph/samba tests are also successful.

@danieldk danieldk merged commit 704bd03 into NixOS:master Jul 18, 2020
@prusnak prusnak deleted the rocksdb branch July 18, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@magenbluten magenbluten Awaiting requested review from magenbluten

@adevress adevress Awaiting requested review from adevress

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @danieldk