Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs.stdenv: remove reference to replace tool #93332

Merged
merged 1 commit into from Sep 26, 2020
Merged

docs.stdenv: remove reference to replace tool #93332

merged 1 commit into from Sep 26, 2020

Conversation

wamserma
Copy link
Member

Motivation for this change

The stdenv does now longer implement the substitution commands by calling replace-literal but uses only shell-operations. The comment in the documentation is misleading.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

That is correct:

nixpkgs/pkgs/stdenv/generic/setup.sh

Line 663 in 1e501a4

eval "$var"'=${'"$var"'//"$pattern"/"$replacement"}'

@doronbehar doronbehar merged commit f1d01c9 into NixOS:master Sep 26, 2020
@wamserma wamserma deleted the docs-remove-replace-link branch September 26, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wamserma @doronbehar