Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: re-add option to control the browser backend #93336

Merged
merged 1 commit into from Jul 26, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jul 17, 2020

Motivation for this change

Fix #93273

Things done
  • Tested using sandboxing (nix.useSandbox)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using (qutebrowser)
  • Tested execution of all binary files
  • Determined the impact on package closure size (none)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 17, 2020

So, @con-f-use you were right: something must have changed in the meanwhile and the old method didn't work anymore.
I came up with this and switching backends seems to work: when using webkit you are greeted by a really helpful document that explain the reasons for not using it.

@emmanuelrosa
Copy link
Contributor

The problem with this is that qutebrowser on NixOS has been using the webengine backend for some time. This change suddenly changes to webkit by default, which causes the user to loose their sessions and breaks websites which were working just fine. It's not a big deal for us running NixOS unstable since we expect things to break sometimes, but when this change gets released it will be a problem for qutebrowser users.

Given the qutebrowser devs recommend using webengine, I think it's best to make webengine the default, while still allowing the option to use webkit.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jul 28, 2020

Sorry, I messed up! I must have left "webkit" from when I was testing it.
Of course, wekbit should never be the default. I'll fix it ASAP.

@rnhmjoj rnhmjoj mentioned this pull request Jul 28, 2020
10 tasks
@rnhmjoj rnhmjoj deleted the qute-backend branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qutebrowser fails to start with webkit backend
2 participants