Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/alsa: disable OSSEmulation by default #93372

Merged
merged 1 commit into from Jan 27, 2021
Merged

nixos/alsa: disable OSSEmulation by default #93372

merged 1 commit into from Jan 27, 2021

Conversation

bb2020
Copy link
Member

@bb2020 bb2020 commented Jul 17, 2020

This was also discussed here: #54074.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Can you put the motivation into the commit message? I also think we could do with a release note.

@bb2020 bb2020 force-pushed the oss branch 2 times, most recently from 9a31aa7 to 574892a Compare July 31, 2020 18:55
@bb2020
Copy link
Member Author

bb2020 commented Jul 31, 2020

Done

raboof
raboof reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but I guess the release note should be moved from 2009 to 2103 now

@bb2020
Copy link
Member Author

bb2020 commented Oct 19, 2020

Right. Updated it now.

@bb2020 bb2020 requested a review from raboof December 8, 2020 14:40
@bb2020
Copy link
Member Author

bb2020 commented Jan 26, 2021

Any update on this getting merged?

@bb2020
nixos/alsa: disable OSSEmulation by default
603e14c 
OSS Emulation is considered incomplete so disabling it by default.
Using user level alsa-oss library (nix-env -iA nixos.alsaOss) over
this kernel module is recommended.
@worldofpeace worldofpeace merged commit ebc22e9 into NixOS:master Jan 27, 2021
@worldofpeace
Copy link
Contributor

Thank you for your patience ✨

@bb2020
Copy link
Member Author

bb2020 commented Jan 27, 2021

Thanks!

@bb2020 bb2020 deleted the oss branch April 10, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bb2020 @worldofpeace @raboof @SuperSandro2000