Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mattermost: 5.15.0 -> 5.25.0 #93360

Merged
merged 1 commit into from Jul 31, 2020
Merged

mattermost: 5.15.0 -> 5.25.0 #93360

merged 1 commit into from Jul 31, 2020

Conversation

ali-abrar
Copy link
Contributor

@ali-abrar ali-abrar commented Jul 17, 2020 •
edited

Motivation for this change

From the mattermost docs:

Support for server Extended Support Release (ESR) 5.19 is coming to the end of its lifecycle on October 15th, 2020. Upgrading to server v5.25 or later is highly recommended.

There are a couple of other pull requests bumping mattermost, but they did not update it to the recommended version (5.25).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and ryantm July 17, 2020 18:28
@ryantm
Copy link
Member

ryantm commented Jul 30, 2020

Thanks! I'm trying this out now. How long have you been using it?

@ryantm
Copy link
Member

ryantm commented Jul 31, 2020

This works for me!

@ryantm ryantm merged commit 7a1dfb5 into NixOS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ali-abrar @ryantm