Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exim: 4.93 -> 4.94 #93356

Merged
merged 1 commit into from Jul 19, 2020
Merged

exim: 4.93 -> 4.94 #93356

merged 1 commit into from Jul 19, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 17, 2020 •
edited

Motivation for this change

Upstream release. Also adds @dasJ and me as maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested review from dasJ and 4z3 July 17, 2020 17:39
dasJ
dasJ approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, running this in production right now

danieldk
danieldk suggested changes Jul 19, 2020
View reviewed changes
pkgs/servers/mail/exim/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from dasJ July 19, 2020 15:39
danieldk
danieldk approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93356 1

1 package built:
- exim

Also tested some of the binaries. I am not an Exim user and it seem that we do not have any NixOS tests. But since @dasJ has also tested this and is a minor version bump, looks good to go.

@danieldk danieldk merged commit 8a29166 into NixOS:master Jul 19, 2020
@ajs124 ajs124 deleted the upd/exim branch July 19, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@4z3 4z3 Awaiting requested review from 4z3

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @danieldk @dasJ