exim: add DMARC support #93357
exim: add DMARC support #93357
Conversation
| { stdenv, fetchFromGitHub, autoreconfHook, libmilter }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "libopendmarc"; |
There was a problem hiding this comment.
This is not just a library, but also contains useful standalone programs. So, it is probably better to call this derivation opendmarc. I propose to move it to pkgs/tools/networking/mail/opendmarc. Then you could also add
outputs = [ "bin" "dev" "out" ];
After the src attribute, so that e.g. exim doesn't get the headers or binaries in its closure. Or that if someone installs the binary output that they don't get the headers.
There was a problem hiding this comment.
Splitting leads to a dependency cycle, because something in share/doc in out references stuff in bin.
There was a problem hiding this comment.
It's only in the documentation. So, the references could be removed, or you could make documentation a separate output:
outputs = [ "bin" "dev" "out" "doc" ];
In this case that would be the most elegant solution.
There was a problem hiding this comment.
done. I think this will mainly be used as a library, which is why I chose development/libraries instead of tools. Lots of "libraries", e.g. openssl, ship tools and example binaries, but they're still in this folder.
There was a problem hiding this comment.
Ack on the directory. But upstream calls the project opendmarc and not libopendmarc, so to me opendmarc is more appropriate as pname and the directory name (thus development/libraries/opendmarc).
There was a problem hiding this comment.
👍 I also changed the name of the attribute in all-packages.nix.
ajs124
force-pushed
the
feat/exim-dmarc
branch
2 times, most recently
from
74741c8
to
236116c
Compare
|
Thanks for making all the changes. Looks almost good to go, I just noticed that some of the opendmarc utilities need shebang patching (and possibly wrapping, I didn't check if the modules are included in the Perl distribution): |
Motivation for this change
We're running this.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)