Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppeteer-cli: init #93321

Merged
merged 3 commits into from Jan 15, 2021
Merged

puppeteer-cli: init #93321

merged 3 commits into from Jan 15, 2021

Conversation

chessai
Copy link
Member

@chessai chessai commented Jul 17, 2020

Motivation for this change

add puppeteer-cli tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chessai
Copy link
Member Author

chessai commented Jul 17, 2020

I don't quite understand the error. If anyone can tell what it means, please let me know. Thanks

@chessai
Copy link
Member Author

chessai commented Jul 17, 2020

Apparently, mkYarnPackage uses IFD to turn package.json into yarn.nix

and i need to use yarn2nix (the binary) to generate a yarn.nix file and then set yarnNix = ./yarn.nix; to skip the IFD step

@stale
Copy link

stale bot commented Jan 15, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 15, 2021
@7c6f434c 7c6f434c merged commit 35da03c into NixOS:master Jan 15, 2021
@dotlambda
Copy link
Member

@7c6f434c Can you please explain why this was merged without meta and properly formatted commit messages?

@7c6f434c
Copy link
Member

7c6f434c commented Sep 7, 2023

Wait, license (specified in the data) doesn't get put into meta.license? missed that.

@dotlambda
Copy link
Member

Oh, I didn't know mkYarnPackage also populates meta with data from package.json. However, meta.homepage and meta.maintainers are missing.

@7c6f434c
Copy link
Member

7c6f434c commented Sep 7, 2023

I am not strict about homepage even now (and about commit naming if at least some commits are named well enough to be searchable), and I wasn't worrying much about maintainership record two and a half years ago, I admit that.

More constructively and forward-looking: @chessai would you add yourself as a maintainer here?

@chessai
Copy link
Member Author

chessai commented Sep 7, 2023

I am not strict about homepage even now (and about commit naming if at least some commits are named well enough to be searchable), and I wasn't worrying much about maintainership record two and a half years ago, I admit that.

More constructively and forward-looking: @chessai would you add yourself as a maintainer here?

yes

@dotlambda
Copy link
Member

I am not strict about homepage even now (and about commit naming if at least some commits are named well enough to be searchable)

I think we should care about homepages. An easy-to-click link to use during reviews is worth a lot.
Here, the commits should have been squashed and the first one should have mentioned the version. That's our convention outlined in the contributing guidelines. If you want to merge PRs you should be willing to follow those.

@dotlambda
Copy link
Member

This adds the missing meta attributes and adds @chessai as maintainer: #253749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants