Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newman: init at 5.2.0 #92986

Merged
merged 1 commit into from Sep 11, 2020
Merged

newman: init at 5.2.0 #92986

merged 1 commit into from Sep 11, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Jul 12, 2020

Motivation for this change

Package new application

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor Author

inspiration from package spacegun: pkgs/applications/networking/cluster/spacegun

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/223

@freezeboy freezeboy force-pushed the add-newman branch 3 times, most recently from eecb45a to c33cc7b Compare August 14, 2020 08:05
@freezeboy freezeboy mentioned this pull request Sep 11, 2020
10 tasks
@freezeboy freezeboy changed the title newman: init at 5.1.1 newman: init at 5.2.0 Sep 11, 2020
@doronbehar
Copy link
Contributor

Works as far as --help and run --help are concerned. Tested with `nixpkgs-review.

@doronbehar doronbehar merged commit b38c90c into NixOS:master Sep 11, 2020
@freezeboy freezeboy deleted the add-newman branch September 11, 2020 21:25
@freezeboy freezeboy mentioned this pull request Sep 12, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants