Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/users-groups: fix mkChangedOptionModule for root password hash #92933

Merged
merged 1 commit into from Jul 12, 2020
Merged

nixos/users-groups: fix mkChangedOptionModule for root password hash #92933

merged 1 commit into from Jul 12, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

Fixed #92910

Things done

Deployed previously broken machine, deployment succeeded with this fix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rnhmjoj
rnhmjoj requested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the commit to nixos/users-groups: fix mkChangedOptionModule for root password hash?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jul 11, 2020

Also, thank you for opening the PR.

@RaghavSood
Copy link
Member Author

@rnhmjoj I've updated the commit message, thanks for checking the issue and PR so quickly!

@RaghavSood RaghavSood changed the title config: users-groups: fix mkChangedOptionModule for root password hash nixos/users-groups: fix mkChangedOptionModule for root password hash Jul 12, 2020
@RaghavSood RaghavSood requested a review from rnhmjoj July 12, 2020 02:27
@flokli flokli merged commit b7ff71a into NixOS:master Jul 12, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jul 12, 2020

Thank you @Floki and @RaghavSood. Sorry for the trouble.

@RaghavSood
Copy link
Member Author

@rnhmjoj No trouble at all, thanks for the opportunity of making my first non-package PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixpkgs-unstable: attribute 'initialHashedPassword' missing, even when it is provided
3 participants
@RaghavSood @rnhmjoj @flokli