Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxx: 2.2.3 -> 2.2.4 #92853

Closed
wants to merge 1 commit into from
Closed

mixxx: 2.2.3 -> 2.2.4 #92853

wants to merge 1 commit into from

Conversation

ejpcmac
Copy link
Contributor

@ejpcmac ejpcmac commented Jul 10, 2020 •
edited

Motivation for this change

A new patch version bringing new controllers support is available and not yet in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Jul 10, 2020

Duplicate of #92482

@prusnak prusnak marked this as a duplicate of #92482 Jul 10, 2020
@ejpcmac
Copy link
Contributor Author

ejpcmac commented Jul 11, 2020

Duplicate of #92482

Oh, my bad! I’d simply checked the version in master but forgot to look in the PRs. I’m closing this one then.

@ejpcmac ejpcmac closed this Jul 11, 2020
@ejpcmac ejpcmac deleted the update-mixxx branch August 27, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@bfortz bfortz Awaiting requested review from bfortz

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejpcmac @prusnak