Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displaylink: 5.2.14 -> 5.3.1 #92918

Merged
merged 2 commits into from Jul 16, 2020
Merged

displaylink: 5.2.14 -> 5.3.1 #92918

merged 2 commits into from Jul 16, 2020

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Jul 11, 2020 •
edited

Motivation for this change

Update version, needs to be merged with #92917 - tested to work together.
There is a dub of this PR, that I did not notice till now - #91129

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb eyJhb mentioned this pull request Jul 11, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from abbradar, peterhoeg and nshalman July 11, 2020 20:59
nshalman
nshalman approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@nshalman nshalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine and it worked for me, along with sibling #92917

@nshalman nshalman mentioned this pull request Jul 14, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from nshalman July 16, 2020 08:49
@srhb srhb merged commit 8ff778c into NixOS:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshalman nshalman nshalman approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @nshalman @srhb