Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.46.1 -> 1.47.3 #92894

Merged
merged 1 commit into from Jul 28, 2020
Merged

vscode, vscodium: 1.46.1 -> 1.47.3 #92894

merged 1 commit into from Jul 28, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jul 10, 2020

Motivation for this change

Upgrade packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 July 10, 2020 20:12
eadwu
eadwu approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified hashes.

@CheariX
Copy link
Contributor

CheariX commented Jul 13, 2020

LGTM. Tested on NixOS.

@CheariX
Copy link
Contributor

CheariX commented Jul 16, 2020

1.47.1 is out, including important security fixes.

@kuznero
Copy link
Member Author

kuznero commented Jul 18, 2020

Microsoft had rapidly release 2 more versions.

@kuznero kuznero changed the title vscode, vscodium: 1.46.1 -> 1.47.0 vscode, vscodium: 1.46.1 -> 1.47.2 Jul 18, 2020
@ofborg ofborg bot requested a review from eadwu July 18, 2020 18:49
@kuznero
Copy link
Member Author

kuznero commented Jul 21, 2020

Ready to be merged

@kuznero
Copy link
Member Author

kuznero commented Jul 24, 2020

Is there anything in Nixpkgs ecosystem that will allow to merge this simple version bumps granted all the ofborg checks pass? Or if possible, I would like to volunteer and merge it myself (if to be considered ok by responsible people). Otherwise, it is ready to be merged. cc @Mic92.

@CheariX
Copy link
Contributor

CheariX commented Jul 28, 2020

I'm using this update now for more than a week. LGTM.

Btw. 1.47.3 has been released :)

@kuznero kuznero changed the title vscode, vscodium: 1.46.1 -> 1.47.2 vscode, vscodium: 1.46.1 -> 1.47.3 Jul 28, 2020
@kuznero
Copy link
Member Author

kuznero commented Jul 28, 2020

I'm using this update now for more than a week. LGTM.

Btw. 1.47.3 has been released :)

Bumped it to 1.47.3 now ;) MS guys are fast these days ;)

@infinisil infinisil merged commit 0633522 into NixOS:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuznero @CheariX @eadwu @infinisil