inkcut: init at 2.1.1 #92990
Merged
inkcut: init at 2.1.1 #92990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erictapen
requested changes
Jul 12, 2020
erictapen
approved these changes
Jul 13, 2020
jonringer
reviewed
Jul 13, 2020
|
(converting to draft since I want to look into cleaning up the qt-reactor packaging) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-are-your-goals-for-20-09/8035/7 |
raboof
force-pushed
the
nixpkgs-inkcut
branch
2 times, most recently
from
0c1258e
to
6630711
Compare
|
(split into commit-per-package and fixed up the qreactor package) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jonringer
reviewed
Aug 3, 2020
jonringer
reviewed
Aug 10, 2020
There was a problem hiding this comment.
please address the failing builds:
[14 built (2 failed), 6 copied (464.3 MiB), 52.0 MiB DL]
error: build of '/nix/store/24jny6q4nkfdxjl5zwxv3vwf5lj6nw8i-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/92990
2 packages failed to build:
python27Packages.bytecode python27Packages.qreactor
9 packages built:
inkcut python37Packages.bytecode python37Packages.enaml python37Packages.enamlx python37Packages.qreactor python38Packages.bytecode python38Packages.enaml python38Packages.enamlx python38Packages.qreactor
appears to be from missing "aenum", you may need to do:
propagateBuildInputs = [ ... ] ++ lib.optionals (pythonOlder "3.6") [ aenum];
example failure:
ERROR: Could not find a version that satisfies the requirement aenum>=2.0; python_version < "3.6" (from bytecode==0.11.0) (from versions: none)
ERROR: No matching distribution found for aenum>=2.0; python_version < "3.6" (from bytecode==0.11.0)
builder for '/nix/store/412b3qkcm3frbawrj99lvqx0hcd2ff7d-python2.7-qreactor-unstable-2018-09-29.drv' failed
since this also affect python3.5, I would like to have the optional dependencies included.
jonringer
approved these changes
Aug 10, 2020
|
Thanks for all the reviewing and pointers, I'm learning a lot ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Great application for driving vinyl cutter machines
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)