New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap7: init at 1.4.2 #92880
snap7: init at 1.4.2 #92880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta
section is missing; see https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes for more info
@symphorien is it ok for you now ? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
The new dev output is not correctly populated:
|
is it ok to link the lib folder from $out to $dev ? |
oh you meant the include folder maybe ? I fixed that locally |
no you should move it. The goal of multiple outputs is that executables depending on the .so (the $out output) do not bring the headers with them at all (the $dev output). |
yes so the lib folder in $out and the include folder in $dev, right ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. You probably should squash your commits according to CONTRIBUTING.md
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
the commit message still says 1.4.0, should be 1.4.2 |
Motivation for this change
Make snap7 library package
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)