Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picmi: init at 19.12.3 #92878

Merged
merged 3 commits into from Jul 13, 2020
Merged

picmi: init at 19.12.3 #92878

merged 3 commits into from Jul 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Jul 10, 2020 •
edited

Motivation for this change

Make picmi app available in kdeApplications

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy requested a review from ttuegel as a code owner July 10, 2020 17:24
@freezeboy
Copy link
Contributor Author

No idea what this error means. local build is ok

@freezeboy
Copy link
Contributor Author

was a problem with my overlay, wrong path fixed in previous commit

@ttuegel ttuegel merged commit 19f85b0 into NixOS:master Jul 13, 2020
@freezeboy freezeboy deleted the add-picmi branch July 25, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @ttuegel