Skip to content

[20.03] fontconfig_210: mark as insecure #92921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[20.03] fontconfig_210: mark as insecure #92921

wants to merge 1 commit into from
+2 −0

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 11, 2020

Motivation for this change

Same as #92919, but instead of removing, mark it as insecure for 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/nixos-release-managers

Sorry, something went wrong.

@flokli flokli added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jul 11, 2020
@flokli flokli requested review from vcunat and worldofpeace July 11, 2020 11:23
This was referenced Jul 11, 2020
Closed
Closed
@flokli flokli force-pushed the 20.03-fontconfig_210_insecure branch from a2e3a53 to 8dbaa0e Compare July 11, 2020 11:30
@vcunat
Copy link
Member

vcunat commented Jul 11, 2020 •
edited
Loading

I think the package is used to generate the default /etc/fonts/fonts.conf, perhaps even on nixpkgs master... so at the very least we should make sure that keeps working without needing the insecure overrides.

@flokli
Copy link
Contributor Author

flokli commented Jul 11, 2020

As discovered in #92919 (comment), we might end up removing the 2.10 fontconfig generation in master with #73795.

It'd probably be fine to backport that commit for 20.03 (and then cherry-pick the "mark package as insecure" commit from here), but we can't mark it as insecure for now here or on master.

@flokli flokli closed this Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim

@vcunat vcunat

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @vcunat @Valodim