Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools/ unit tests #24557

Merged
merged 4 commits into from Jul 10, 2020
Merged

Fix tools/ unit tests #24557

merged 4 commits into from Jul 10, 2020

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Jul 10, 2020

  1. Fix an incorrect type annotation in lint.py introduced in [lint] Allow multiple --ignore-glob in wpt lint #24520 accidentally.
  2. Disable coverage collection in quic/ to silence some warnings.
  3. Temporarily disable a mysterious error on Windows+py3 regarding datetime.strptime (test_verify_taskcluster_yml fails on Windows in Python 3 #24561).

Drive-by: change docker-worker schema URL

This was introduced in #24520 accidentally.
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24557 July 10, 2020 14:30 Inactive
quic/ contains Python 3-only code that leads to warnings when running
`pytest --cov` in Python 2.
@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24557 July 10, 2020 15:26 Pending
@Hexcles Hexcles changed the title [lint] Fix a type annotation Fix tools/ unit tests Jul 10, 2020
@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-24557 July 10, 2020 15:34 Pending
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24557 July 10, 2020 15:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants