Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bovo: init at 19.12.3 #92974

Merged
merged 3 commits into from Jul 13, 2020
Merged

bovo: init at 19.12.3 #92974

merged 3 commits into from Jul 13, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Jul 12, 2020 •
edited

Motivation for this change

Package missing kde game

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy requested a review from ttuegel as a code owner July 12, 2020 05:37
@ttuegel
Copy link
Member

ttuegel commented Jul 12, 2020

The new package should be pulled into the top-level set. I can't link to it on GitHub because the file is too large, but look for a line beginning with inherit (kdeApplications) in pkgs/top-level/all-packages.nix.

@ttuegel ttuegel merged commit 0696f88 into NixOS:master Jul 13, 2020
@freezeboy freezeboy deleted the add-bovo branch July 25, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @ttuegel