Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.dash-to-panel: 31 -> 38 #92926

Merged
merged 1 commit into from Jul 13, 2020
Merged

gnomeExtensions.dash-to-panel: 31 -> 38 #92926

merged 1 commit into from Jul 13, 2020

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Jul 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rawkode rawkode requested review from hedning and LnL7 July 11, 2020 12:45
@rawkode
Copy link
Member Author

rawkode commented Jul 11, 2020

The latest version fixes the broken "Overview" behaviour with GNOME 3.36.4

https://github.com/home-sweet-gnome/dash-to-panel/releases

@buckley310
Copy link
Contributor

This patch works for me.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 11, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 13, 2020

Changes look okay, thanks.

@jtojnar jtojnar merged commit cb9a3a0 into NixOS:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rawkode @buckley310 @jtojnar