Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php74: 7.4.7 -> 7.4.8 #92925

Merged
merged 1 commit into from
Jul 11, 2020
Merged

php74: 7.4.7 -> 7.4.8 #92925

merged 1 commit into from
Jul 11, 2020
+3 −2

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 11, 2020 •
edited
Loading

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.4.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@etu etu requested review from ckauhaus and a team July 11, 2020 12:44
@Ma27
Copy link
Member

Ma27 commented Jul 11, 2020

@etu I assume want to backport this to stable (and also the php73/php72 updates), right?

@etu
Copy link
Contributor Author

etu commented Jul 11, 2020

@Ma27 Correct, I will flag all three PR's with that label. Also the security label.

@etu etu added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 11, 2020
@etu
Copy link
Contributor Author

etu commented Jul 11, 2020

@ofborg build php74

@Ma27
Copy link
Member

Ma27 commented Jul 11, 2020

mysqlnd fails to build:

php-mysqlnd> applying patch /nix/store/qah4sfz2p2azgh51xs866igyayjbsix1-mysqlnd_fix_compression.patch
php-mysqlnd> patching file ext/mysqlnd/mysqlnd.h
php-mysqlnd> Reversed (or previously applied) patch detected!  Assume -R? [n]
php-mysqlnd> Apply anyway? [n]
php-mysqlnd> Skipping patch.
php-mysqlnd> 1 out of 1 hunk ignored -- saving rejects to file ext/mysqlnd/mysqlnd.h.rej

@etu
php74: 7.4.7 -> 7.4.8

Verified

This commit was signed with the committer’s verified signature.
siriobalmelli Sirio Balmelli
GPG key ID: 0437A96EFE4C426E
Verified
Learn about vigilant mode
49316cc 
Changelog: https://www.php.net/ChangeLog-7.php#7.4.8
@etu
Copy link
Contributor Author

etu commented Jul 11, 2020

@ofborg build php74

@Ma27
Copy link
Member

Ma27 commented Jul 11, 2020

@ofborg eval

@Ma27 Ma27 merged commit 2423213 into NixOS:master Jul 11, 2020
@Ma27
Copy link
Member

Ma27 commented Jul 11, 2020

Thanks! Backported as b2459a1.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 11, 2020
@etu etu deleted the php74-update branch July 11, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27

@ckauhaus ckauhaus

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @Ma27