Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: update #92949

Merged
merged 1 commit into from Jul 12, 2020
Merged

jetbrains: update #92949

merged 1 commit into from Jul 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2020 •
edited by ghost

Motivation for this change

I also manually updated the part of the MPS download url that is not changed automatically by the updater script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from edwtjo as a code owner July 11, 2020 17:58
@ghost ghost requested review from ktor and Ma27 July 11, 2020 17:59
@eyJhb
Copy link
Member

eyJhb commented Jul 11, 2020

Remember to follow conventions, jetbrains: 2020.1.3 -> 2020.1.4 both in the PR title and commit messages :)

@Ma27
Copy link
Member

Ma27 commented Jul 11, 2020

@eyJhb there are multiple packages with different version bumps. Since the updates are automatically generated, the commit-message is fine IMHO.

@eyJhb
Copy link
Member

eyJhb commented Jul 11, 2020

@eyJhb there are multiple packages with different version bumps. Since the updates are automatically generated, the commit-message is fine IMHO.

My bad, there were a few that weren't the same. Sorry for the disturbance ;)

@Ma27 Ma27 merged commit 83182f4 into NixOS:master Jul 12, 2020
@Ma27
Copy link
Member

Ma27 commented Jul 12, 2020

@petabyteboy thanks!

@r-k-b r-k-b mentioned this pull request Aug 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @Ma27 @ktor