Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.packages.phpstan: 0.12.25 -> 0.12.32 #92953

Merged
merged 1 commit into from Jul 17, 2020
Merged

php.packages.phpstan: 0.12.25 -> 0.12.32 #92953

merged 1 commit into from Jul 17, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Jul 11, 2020

Motivation for this change

Changelogs:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from a team July 11, 2020 18:49
@ofborg ofborg bot requested review from Ma27, talyz, aanderse and globin July 11, 2020 23:45
@Ma27 Ma27 merged commit 5b38c1d into NixOS:master Jul 17, 2020
@etu etu deleted the phpstan-update branch July 19, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

@talyz talyz Awaiting requested review from talyz talyz is a code owner

@aanderse aanderse Awaiting requested review from aanderse aanderse is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @Ma27