Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nixos make-disk-image: fix permissions of /build #92952

Closed
wants to merge 1 commit into from
Closed

[20.03] nixos make-disk-image: fix permissions of /build #92952

wants to merge 1 commit into from

Conversation

txt-file
Copy link

Motivation for this change

Be able to create raw images with nixos-generators.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus @txt-file
nixos make-disk-image: fix permissions of /build
65bcdc9 
This was broken in 460c0d6 (PR #90431); now the nixos-unstable channel
should get unblocked.
vcunat modified this commit to use env-var instead of hardcoding /build

(cherry picked from commit 8d05772)
@txt-file
Copy link
Author

linked pull request: #90431

@txt-file txt-file changed the title nixos make-disk-image: fix permissions of /build [20.03] nixos make-disk-image: fix permissions of /build Jul 11, 2020
@cole-h
Copy link
Member

cole-h commented Jul 11, 2020

This shouldn't be necessary, considering #90431 (which introduced this problem) isn't present on 20.03.

@txt-file
Copy link
Author

I will recheck that.

@txt-file txt-file marked this pull request as draft July 11, 2020 21:24
@txt-file
Copy link
Author

@cole-h is right.

@txt-file txt-file closed this Jul 12, 2020
@txt-file txt-file deleted the release-20.03 branch July 12, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@txt-file @cole-h @Lassulus