Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python27Packages.pillow: fix build on darwin #92905

Merged
merged 1 commit into from
Jul 11, 2020
Merged

python27Packages.pillow: fix build on darwin #92905

merged 1 commit into from
Jul 11, 2020
+1 −1

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 11, 2020

Motivation for this change

fixes #92818

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@marsam marsam requested review from FRidh and jonringer as code owners July 11, 2020 03:03
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 11, 2020
@marsam
Copy link
Contributor Author

marsam commented Jul 11, 2020

@GrahamcOfBorg build nixops
@GrahamcOfBorg build calibre

@ofborg ofborg bot requested review from cillianderoiste and prikhi July 11, 2020 03:10
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 11, 2020
@marsam marsam merged commit b6b8f39 into NixOS:master Jul 11, 2020
@marsam marsam deleted the fix-pillow-darwin branch July 11, 2020 18:23
@evanjs
Copy link
Member

evanjs commented Jul 11, 2020

Thanks for resolving this issue!
I'm glad it wasn't anything major 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

@cillianderoiste cillianderoiste

@prikhi prikhi

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixops-1.7 sub-dependency python2.7-Pillow-6.2.2 build fails on macOS
2 participants
@marsam @evanjs