Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpm-tools: Specify dependencies and wrap executables #92966

Merged
merged 1 commit into from Jul 12, 2020
Merged

bpm-tools: Specify dependencies and wrap executables #92966

merged 1 commit into from Jul 12, 2020

Conversation

f4814
Copy link
Contributor

@f4814 f4814 commented Jul 11, 2020

Motivation for this change

The scripts would fail if the required dependencies (gnuplot, flac, id3v2, vorbis-tools, sox) were not (by sheer coincidence) in $PATH.

Things done

Add the required packages as input of this derivation and wrap the scripts so the dependencies are in $PATH.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from doronbehar July 12, 2020 01:58
@f4814
Copy link
Contributor Author

f4814 commented Jul 12, 2020

Implemented all your suggestions. Thanks for the feedback @doronbehar @jtojnar

@ofborg ofborg bot requested a review from doronbehar July 12, 2020 10:06
@ofborg ofborg bot requested a review from doronbehar July 12, 2020 11:32
@jtojnar jtojnar merged commit 3518436 into NixOS:master Jul 12, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 12, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f4814 @jtojnar @doronbehar