Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03]: haskellPackages.lambdabot: Drop broken overrides #92963

Merged
merged 1 commit into from Jul 12, 2020
Merged

[20.03]: haskellPackages.lambdabot: Drop broken overrides #92963

merged 1 commit into from Jul 12, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jul 11, 2020 •
edited

Fix #92256

Direct to release-20.03, since a more wide-ranging fix has already hit master, which I don't think is quite necessary in 20.03.
haskellPackages.lambdabot remains broken.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskellPackages.lambdabot
@GrahamcOfBorg build haskellPackages.lambdabot-core
@GrahamcOfBorg build haskellPackages.lambdabot-reference-plugins
@GrahamcOfBorg build haskellPackages.lambdabot-haskell-plugins

@cdepillabout
Copy link
Member

@srhb Thanks for trying to fix this up.

Just to be clear, in this PR you're not trying to get haskellPackages.lambdabot compiling, you're just trying to get rid of the use of the non-existing hslogger_1_3_0_0 attribute?

In that case, I think this PR looks good, and nix-env --query --available --out-path --file ./. --show-trace is now able to be run successfully.

@srhb
Copy link
Contributor Author

srhb commented Jul 12, 2020

@cdepillabout Correct. :)

@cdepillabout
Copy link
Member

Okay, sounds good, thanks for taking the time to fix this!

@cdepillabout cdepillabout merged commit 674ab2d into NixOS:release-20.03 Jul 12, 2020
@cdepillabout cdepillabout mentioned this pull request Jul 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @cdepillabout