Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uboot: add hydra-build-products #92969

Merged
merged 1 commit into from Jun 28, 2021
Merged

uboot: add hydra-build-products #92969

merged 1 commit into from Jun 28, 2021

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

This will allow users to easily download the bootloader for their device without having Nix installed.

This is what it looks like on my Hydra instance (for ubootRockPro64):
image

Right now, this PR applies to ubootTools as well, but I could make a flag to disable it there if you think that would be better.

cc @samueldr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
uboot: add hydra-build-products
6a0bb38 
This allows users to easily download the bootloader for their device without
having Nix installed.
@lopsided98
Copy link
Contributor Author

My browser tries to load u-boot.itb as a text file, but not idbloader.img.

@ofborg ofborg bot requested review from samueldr and dezgeg July 12, 2020 02:09
@samueldr
Copy link
Member

samueldr commented Jul 12, 2020 •
edited

I don't know if the nixos.org hydra instance would act differently with regards to downloads.

Isn't that also driven by the HTTPD?

@edolstra any reason not to provide an hydra build product?

@samueldr samueldr requested a review from edolstra July 12, 2020 18:32
@lopsided98
Copy link
Contributor Author

We got a request for this feature on IRC today: https://logs.nix.samueldr.com/nixos/2020-11-17#4247715;

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@lopsided98
Copy link
Contributor Author

I still think this is a good idea to have.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2021
@samueldr
Copy link
Member

I agree.

Even though in practice I hope Tow-Boot dislodges the need for distribution-built U-Boot binaries, we don't actually customize the builds*, so they are a source of "true to upstream" U-Boot, and this would still have value, in having binaries more readily accessible.

* some patches may not have been sent upstream yet, but are not meant to change the actual behaviour.

@samueldr
Copy link
Member

I guess we gave enough time to anyone to react about using the hydra build products feature.

@samueldr samueldr merged commit 03344a1 into NixOS:master Jun 28, 2021
@lopsided98 lopsided98 deleted the uboot-hydra-build-products branch June 28, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

@dasJ dasJ dasJ approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @samueldr @dasJ