Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sndio: 1.6.0 -> 1.7.0 #92978

Merged
merged 2 commits into from Sep 6, 2020
Merged

sndio: 1.6.0 -> 1.7.0 #92978

merged 2 commits into from Sep 6, 2020

Conversation

S-NA
Copy link
Contributor

@S-NA S-NA commented Jul 12, 2020

Motivation for this change

Updates sndio to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Chiiruno July 12, 2020 06:39
@risicle
Copy link
Contributor

risicle commented Sep 5, 2020

Fails to build on macos (10.14):

mkdir -p /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/bin /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/share/man/man1
  cp midicat /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/bin
  cp midicat.1 /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/share/man/man1
  make[1]: Leaving directory '/private/tmp/nix-build-sndio-1.7.0.drv-0/sndio-1.7.0/midicat'
  post-installation fixup
  gzipping man pages under /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/share/man/
  strip is /nix/store/gmhd52yac3w4zk8xqsgh97makjh8gi7l-cctools-binutils-darwin-927.0.2/bin/strip
  stripping (with command strip and flags -S) in /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/lib  /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/bin 
  patching script interpreter paths in /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0
  error: install_name_tool: can't open file: /nix/store/mq3gi0vq1jarrzhk9qg8pn4pvhiyjnv5-sndio-1.7.0/lib/libsndio.7.0.dylib (No such file or directory)

Rather than chasing the exact .dylib name in a postFixup all the time, it does seem to work if you simply add fixDarwinDylibNames to the build inputs if stdenv.isDarwin.

Also, obviously, could do with a rebase.

@S-NA
sndio: 1.6.0 -> 1.7.0
bc57f6d 
Updates sndio to the latest version.
@S-NA
sndio: fix up for Darwin
96bd235 
Applying the suggestion by @risicle to use fixDarwinDylibNames instead
of manually chasing the exact .dylib name in postFixup.
@risicle
Copy link
Contributor

risicle commented Sep 6, 2020

WFM, macos 10.14, non-nixos linux x86_64.

@risicle risicle merged commit 45a4fa7 into NixOS:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@S-NA @risicle