Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm-opencl-icd: init at 3.5.0 #92892

Closed
wants to merge 9 commits into from
Closed

rocm-opencl-icd: init at 3.5.0 #92892

wants to merge 9 commits into from

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 10, 2020 •
edited

Motivation for this change

This is not for reviewing yet!

As discussed in #92219 I am preparing a PR that imports some of the NixOS-rocm packages into nixpkgs (enough to get OpenCL support). This WIP PR is to test if the packages build outside my machine ;).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title Amd rocm-opencl-icd: init at 3.5.0 Jul 10, 2020
@danieldk
Copy link
Contributor Author

@ofborg build rocm-opencl-icd

@danieldk danieldk closed this Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: hardware 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @veprbl